TexasInstruments / processor-sdk-doc

Processor SDK (PSDK) documentation source
https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/latest/exports/docs/devices/AM62X/index.html
Creative Commons Attribution Share Alike 4.0 International
6 stars 13 forks source link

Create a CODEOWNERS file to auto assign reviewers #8

Open DhruvaG2000 opened 4 weeks ago

DhruvaG2000 commented 4 weeks ago

We need to add a CODEOWNERS file [1] to this repo so that we can auto assign reviewers.

[1] https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

DhruvaG2000 commented 1 week ago

We should take inspiration from how it's being done in Zephyr: https://github.com/zephyrproject-rtos/zephyr/blob/main/CODEOWNERS

If you see their file too has "Errors" according to github, but they don't use the "Github" way of assiging reviewers it seems like they do some amount of scripting here: https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/workflows/assigner.yml which ultimately runs a python script: https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/set_assignees.py

This script then parses https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml and then auto assigns reviewers.

StaticRocket commented 1 week ago

Found a workflow that does the same thing the zephyr project tool was doing, but without reusing the CODEOWNERS format, so it doesn't actually conflict with GitHub right now.

We should be able to run with this until https://github.com/orgs/community/discussions/23042 is resolved.

DhruvaG2000 commented 1 week ago

@StaticRocket no no.. We don't even really need to use CODEOWNERS if you see zephyr python script, it parses the maintainers file. So there's no conflict.

cshilwant commented 1 week ago

until https://github.com/orgs/community/discussions/23042 is resolved.

@StaticRocket I don't think they are thinking to resolve it. I mean the thread was last responded by a GitHub team in 2019 🙂

StaticRocket commented 1 week ago

I have faith. We've had bugs open for longer durations. :)

cshilwant commented 1 week ago

Re-opening this issue (which got auto closed) since the plan is to use https://github.com/TexasInstruments/processor-sdk-doc/pull/32 as well to assign pull requests to default reviewers based on sections.