Closed ThomasGaubert closed 6 years ago
Fixing a non-issue. I don't see an obvious need for this or any major problems that have come from message deletion.
I personally don't see the issue with message deletion either, but the issue has been brought up throughout the past semester. Adding this provides at least some way of resolving any potential issues in the future (versus right now where nothing can be done).
Agreed, this doesn't really fix anything besides imageme spam, which, while a little annoying, I'd be hard pressed to say it warrants something like this. Maaaaybe karma manipulation, but everyone's gotten bored of that since atchans can't be abused now. More importantly, I don't like it because the script leaks information about private channels - their existence, their members, how they use lanbot - to anyone with access to the server.
More importantly, I don't like it because the script leaks information about private channels - their existence, their members, how they use lanbot - to anyone with access to the server.
It doesn't. Nothing is stored into the database and nothing is logged to any file on the server. The script ignores and throws away anything that is not a command that the bot recognizes (none of which are intended to accept personal information in the first place). History is only displayed for the room in which lanbot history
is used so there's no way to access the history of another room either.
If there was an actual issue, we can just look at slack logs
Continuing on the theme of abuse prevention, track users who have recently used commands. This should help resolve issues relating to message deletion without actually disabling message deletion.
lanbot history
lists the ten most recent commands and who issued each.