search

Textualize / frogmouth

A Markdown browser for your terminal
https://www.textualize.io/
MIT License
2.35k stars 42 forks source link

Update from `xdg` to `xdg-base-dirs` #85

Closed philiptaron closed 8 months ago

philiptaron commented 8 months ago

Per https://github.com/srstevenson/xdg-base-dirs/tree/6.0.0#xdg-base-dirs, the Python library formerly known as xdg is now xdg-base-dirs.

Updating the references causes a bump in minimum supported Python versions from 3.8 to 3.10. This seemed fine to me.

The poetry.lock file was updated using poetry lock.

philiptaron commented 8 months ago

I made this change in response to NixOS's version of frogmouth being broken. https://github.com/NixOS/nixpkgs/pull/263241

davep commented 8 months ago

As per https://github.com/Textualize/frogmouth/pull/59 - unless there's an actual benefit to this I'll keep the Python compatibility. Last I checked there was no difference in the library.

philiptaron commented 8 months ago

Yeah, there's no difference I can see in the actual library... and thus, no reason that the xdg-base-dirs developers ought to raise its minimum Python version to 3.8. 🤕 This entire pain is due to that decision.

davep commented 8 months ago

Yup, there's no obvious benefit in them having raised the minimum Python version. It's an unfortunate decision.