codecov-commenter
commented
7 months ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.28%. Comparing base (
aabfd16) to head (18ebb42). Report is 217 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #3289 +/- ## ========================================== - Coverage 98.30% 98.28% -0.03% ========================================== Files 74 74 Lines 8038 8049 +11 ========================================== + Hits 7902 7911 +9 - Misses 136 138 +2 ``` | [Flag](https://app.codecov.io/gh/Textualize/rich/pull/3289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Textualize/rich/pull/3289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `98.28% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The bug https://github.com/Textualize/textual/issues/4073 showed that the version of wcwidth we are using incorrectly reports the soft hyphen (codepoint 173, 0xAD) as having length 1.
This was fixed in
wcwidth0.2.9, so updatingwcwidthwas enough. I tested it and this fixes the linked Textual issue.