fix(syntax): include padding with background color override

Textualize / rich

Rich is a Python library for rich text and beautiful formatting in the terminal.

https://rich.readthedocs.io/en/latest/

MIT License

49.05k stars 1.71k forks source link

fix(syntax): include padding with background color override #3296

Closed TomJGooding closed 3 months ago

TomJGooding commented 7 months ago

Type of changes

[x] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3295. I've tested manually but I'm afraid not sure how to add a proper test for this.

Before:

After:

TomJGooding commented 7 months ago

I've now added a test based on the others, where I assume you just copy paste the result from print(repr(result)) and then check that? (If Will has actually written these by hand I'm seriously impressed!)

If that's not the proper way to test this, please let me know!