Add new column object: IterationSpeedColumn

Textualize / rich

Rich is a Python library for rich text and beautiful formatting in the terminal.

https://rich.readthedocs.io/en/latest/

MIT License

49.04k stars 1.71k forks source link

Add new column object: IterationSpeedColumn #3332

Closed chthollyphile closed 1 day ago

chthollyphile commented 5 months ago

Type of changes

[ ] Bug fix
[x] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description

This pull request addresses the requirement raised in discussion #926 to add a new column for the number of iterations per second.

willmcgugan commented 3 months ago

Looks good. I'd need tests for the new column. And an entry in the docs.

chthollyphile commented 2 months ago

done.

willmcgugan commented 1 day ago

Thanks

willmcgugan commented 1 day ago

Had to revert this PR I'm afraid. Assigning an attribute with setattr is a deal-breaker. It doesn't play well with static type checkers, and is best avoided. Can you not store the value on the Column object?