search

Textualize / rich

Rich is a Python library for rich text and beautiful formatting in the terminal.
https://rich.readthedocs.io/en/latest/
MIT License
48.88k stars 1.71k forks source link

[REQUEST] Add binary_units argument to all relevant progress columns (TransferSpeedColumn, FileSizeColumn and TotalFileSizeColumn) #3466

Open sbraz opened 3 weeks ago

sbraz commented 3 weeks ago

How would you improve Rich? Hello, In 630ed8bd7f1f5bbe81b2ded4c9fa8bf25e6b7db0 and 5ef33ae7bfa5f0458effbbe2a9add8aaa4ee0bf5, DownloadColumn got support for using multiples of 1024. However, other columns do not have a binary_units argument.

This was already mentioned in https://github.com/Textualize/rich/discussions/2034 and I feel like it would be useful to be consistent with other software.

What problem does it solve for you?

When I'm watching a transfer, I expect sizes to be displayed as multiples of 1024 bytes. This is what rsync --info=progress2, curl, wget and lsblk do. Even ls also does this unless --si is passed.

github-actions[bot] commented 3 weeks ago

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory