pageup and pagedown bindings not firing on `main` branch

Textualize / textual

The lean application framework for Python. Build sophisticated user interfaces with a simple Python API. Run your apps in the terminal and a web browser.

https://textual.textualize.io/

MIT License

24.09k stars 742 forks source link

pageup and pagedown bindings not firing on `main` branch #4632

Closed darrenburns closed 3 weeks ago

darrenburns commented 3 weeks ago

Tested with DataTable and TextArea.

willmcgugan commented 3 weeks ago

Must be an issue with the new keyboard protocol. But I can see them in textual keys. What do you get?

willmcgugan commented 3 weeks ago

Oh I think the name may have change. Textual keys repots "page_up", but the bindings are "pageup".

willmcgugan commented 3 weeks ago

Yeah confirmed. I guess the easiest fix would be to stick with the original name.

willmcgugan commented 3 weeks ago

Pushed to main. Give it a try?

darrenburns commented 3 weeks ago

Working - thanks!

github-actions[bot] commented 3 weeks ago

Don't forget to star the repository!

Follow @textualizeio for Textual updates.