search

Textualize / trogon

Easily turn your Click CLI into a powerful terminal application
MIT License
2.5k stars 54 forks source link

Trogon doesn't work with Textual 0.54.0 #77

Closed daneah closed 8 months ago

daneah commented 8 months ago

When using Textual 0.54.0, the right-side panel with the inputs for building up a command with arguments and options no longer loads.

Explicitly pinning to textual<0.54.0 returns things to working order.

Reproduction here

willmcgugan commented 8 months ago

@darrenburns One for you?

davep commented 8 months ago

Having a quick poke at this and I think I've narrowed it down to this:

#home-sidebar {
  dock: left;
  width: auto;
}

Seems the docked sidebar, now, is going full-width on the screen and pushing everything else out of the way. If you (as a test) set the width to 30, things start to look as they should again. Looks to be down to some difference in the way auto is being handled here.

davep commented 8 months ago

Looks to be a fight between a Label within the sidebar and the sidebar. If I change the above to something like:

#home-sidebar {
  dock: left;
  width: auto;

  & > Label {
      width: auto;
  }
}

it more or less all falls back into place (albeit with the label being more narrow than it would have been before).

Presumably the #home-sidebar doesn't have anything inside it that it can take a width clue from.

davep commented 8 months ago

As a followup: https://github.com/Textualize/textual/issues/4360 seems to be the root cause of this and the workaround added by the PR related to this can be undone if Textual reverts this behaviour.