search

Textualize / trogon

Easily turn your Click CLI into a powerful terminal application
MIT License
2.5k stars 54 forks source link

Actions in footer not working #85

Closed anze3db closed 3 months ago

anze3db commented 4 months ago

I have noticed that actions in the footer no longer work by clicking them or using keyboard shortcuts (C^t, C^s, etc).

The BINDINGS defined in the CommandBuilder class no longer propagate to the parent Trogon class, where the handlers are defined (e.g., action_focus_command_tree).

Moving the BINDINGS to the Trogon class fixes the problem for me. Moving the handlers down to the CommandBuilder does as well, but I'm not sure which solution is better. Could this be an underlying issue with Textual?

I'm happy to open a PR and move the BINDINGS, just let me know if this is an ok solution.

daneah commented 3 months ago

Is this potentially a duplicate of #82 ?

anze3db commented 3 months ago

Ah, yes. Looks like a duplicate. Closing this one, thanks!