search

TextureGroup / Texture

Smooth asynchronous user interfaces for iOS apps.
https://texturegroup.org/
Other
7.99k stars 1.29k forks source link

Texture + IGListKit + Carthage #1113

Open 3a4oT opened 5 years ago

3a4oT commented 5 years ago

Hello. I'm trying to work with Texture + IGListKit + Carthage. I faced with issue where app crash when I call -[IGListAdapter setASDKCollectionNode:]: unrecognized selector sent to instance 0x1997d620 I forked Texture and have modified Carthage file where I have added IGListKit as a dependency. Then have build it again but the error still there. Cartfile of Texture itslef

github "pinterest/PINRemoteImage" "3.0.0-beta.13"
github "pinterest/PINCache" "3.0.1-beta.6"
github "Instagram/IGListKit" == 3.4

From my understanding when IGListKit present on Carthage/Build then #define AS_IG_LIST_KIT from Source/Base/ASAvailability.h gonna to be true so implementation should be available?

3a4oT commented 5 years ago

Ok seems I have found the issue. ASIGListAdapterBasedDataSource.h is not part of Framework's Headers. IGListAdapter+AsyncDisplayKit.m and ASIGListAdapterBasedDataSource.m are not part Framework's Compiled Sources. I have created https://github.com/3a4oT/Texture/tree/ASIGListCarthage branch with the patch that allows use Texture with IGListKit from Carthage.

If you want to give it a try just add in your Cartfile: github "3a4oT/Texture" "ASIGListCarthage"

ptmt commented 5 years ago

Could you please make a PR so maybe it could be merged in master?

ptmt commented 5 years ago

Related: https://github.com/TextureGroup/Texture/issues/254 So it seems that for Carthage users forking the Texture is the only option at the moment