search

TextureGroup / Texture

Smooth asynchronous user interfaces for iOS apps.
https://texturegroup.org/
Other
8.02k stars 1.29k forks source link

ASCellNode accessibility labels not being read correctly #1997

Open ay8s opened 3 years ago

ay8s commented 3 years ago

We recently updated to the latest code from master and got a couple of reports from users that VoiceOver is no longer correctly reading out labels for various cells within the app. Returning back to our older version it works fine. It looks like if I comment out the change from #1941 the labels are read out correctly once more.

I found a couple of cases of similar behavior in the Pinterest app but not sure if these views use ASTableNode specifically on the "Add account" screen nothing is read out aside from a couple of Button traits.

cc @garrettmoon @bolsinga Just in case you're able to replicate and confirm the same behavior on the Pinterest side.

paulgee31 commented 2 years ago

I can confirm that if you comment out the change #1941 that ASCellNode the accessibilityLabel property is read correctly, however with the change in place the label is ignored.