search

TextureGroup / Texture

Smooth asynchronous user interfaces for iOS apps.
https://texturegroup.org/
Other
8.02k stars 1.29k forks source link

Decode alternative image types in ASImageNode at render time #2011

Open brandonli-google opened 3 years ago

brandonli-google commented 3 years ago

Adds support at the Texture level for decoding additional image formats at render time once the final image size is known

The Cartfile changes are because ASPINRemoteImageDownloader currently references API's that don't exist in the older version of PINRemoteImage

See https://github.com/pinterest/PINRemoteImage/pull/602 for corresponding PINRemoteImage change

Upstreamed contribution from Google's fork of Texture

garrettmoon commented 3 years ago

Just to confirm, this change requires the PINRemoteImage change be merged and released?

brandonli-google commented 3 years ago

Just to confirm, this change requires the PINRemoteImage change be merged and released?

Yes, that's right. Could add an additional build directive into PINRemoteImage (like #PINCustomDecoders or something) so that they can go in independently. WDYT?

garrettmoon commented 3 years ago

I don't think that's necessary, PINRemoteImage is due a release soon anyway :)