ASTextLayout truncated line fix when add headIndent or firstLineHeadIndent in NSParagraphStyle

TextureGroup / Texture

Smooth asynchronous user interfaces for iOS apps.

https://texturegroup.org/

Other

8.02k stars 1.3k forks source link

ASTextLayout truncated line fix when add headIndent or firstLineHeadIndent in NSParagraphStyle #2041

Open kanottonp opened 3 years ago

kanottonp commented 3 years ago

Hi Texture Team,

There is an issue about when I insert headIndent or firstLineHeadIndent into NSParagraphStyle and add to NSAttributedString in both ASTextNode or ASTextNode2

Examples test cases for showing truncated line with wrong layout (Truncation Message overflows the box) 1d012ab

So I found a solution for fixing and add test cases for this case too.

Fixing and Add Screenshot Test 9ca2aa2

Hope this helps!

kanottonp commented 3 years ago

Already create pull request at #2042