search

TextureGroup / Texture

Smooth asynchronous user interfaces for iOS apps.
https://texturegroup.org/
Other
8.02k stars 1.29k forks source link

The example `ASRatioLayoutSpec` in the sample Project `AsyncDisplayKitOverview` cannot work as expected #208

Open garrettmoon opened 7 years ago

garrettmoon commented 7 years ago

From @xilin on March 24, 2017 9:30

The sample is located in here.

It seems that the constrainedSize is fixed as {min : {100, 100}, max: {100, 100}} so that the ASRatioLayoutSpec layout cannot produce correct result.

Copied from original issue: facebookarchive/AsyncDisplayKit#3216

garrettmoon commented 7 years ago

From @nguyenhuy on March 29, 2017 14:6

The fixed constrainedSize is for parentNode, and the ratio spec is applied for the childNode of that node. I'd imagine the childNode has a size of {100, 25}, no?

garrettmoon commented 7 years ago

From @xilin on March 29, 2017 16:0

@nguyenhuy Nope. The childNode is in blue color and see the snapshot

simulator screen shot 29 mar 2017 11 59 47 pm

garrettmoon commented 7 years ago

From @nguyenhuy on March 29, 2017 16:6

Oh yeah, you're entirely right. The ratio spec got a fixed size range of {100, 100}! We should fix that!

vdeep commented 6 years ago

Any update on this? How can we try the ASRatioLayoutSpec in the example app?