Closed hu3man closed 2 years ago
Initial notes for Getting started and scaffolding pages (will continue tomorrow):
Notes on website docs testing/run through:
Overall structure notes:
- Requirements sections in plugins/other pages should be standardized with up to date info and in general should have all the same info present
General home page:
- Get started, docs and release notes are black on home page but switch to a yellow colour when in any of the docs sections (clicking on an option of those three)
-
Installation Page:
- We are
Introduction Page:
- Taquito plugin has link extending for an extra word
- "Taqueria is a task runner that you can use from the command line or the VS Code command palette" should this have the command palette part changed/updated? We are no longer just using the command palette
- Same thing as above with command palette under major components section: "A VS Code Extension which provides the ability to run Taqueria tasks from the command palette"
- https://taqueria.io/docs/intro/#taqueria-project has a line for the .taq folder but uses the `./` in front of the directory name, this should be changed to just `.taq/` to be consistent. The following note section is the same way
- https://taqueria.io/docs/intro/#taqueria-plugins needs to have metadata plugin entry added
Quickstart page:
- Requirements section on this page doesn't have a taq version, we should add one in for consistency
- https://taqueria.io/docs/getting-started/quickstart/#requirements mentions the command palette, we should change this wording to jsut mention VSCode extension
- https://taqueria.io/docs/getting-started/quickstart/#starting-a-taqueria-project using `./.taq` should just be `/.taq`
- https://taqueria.io/docs/getting-started/quickstart/#starting-a-flextesa-sandbox has some problem as above with `./.taq`
-
Scaffold basics:
- https://taqueria.io/docs/scaffolds/scaffold-basics/#building-and-starting-scaffolds has `npm run setup` twice, second one should be `npm run start`
- https://taqueria.io/docs/scaffolds/scaffold-basics/#available-scaffolds quickstart mentions a counter contract but scaffold doesn't have that. Likely should be part of the quickstart scaffold refactor
Taco shop scaffold:
- Spelling mistake in https://taqueria.io/docs/scaffolds/taco-shop/#quickstart "Immediatley"
- https://taqueria.io/docs/scaffolds/taco-shop/#overview has `available_tacos` but isn't formatted as code and should be for consistency
- https://taqueria.io/docs/scaffolds/taco-shop/#requirements has beacon or kukai wallet, later on we specifically call out temple so we should probably just tell people to have a temple wallet set up. There is also a faucet file requirement but that no longer exists. Will need to discuss what goes here
- https://taqueria.io/docs/scaffolds/taco-shop/#react-dapp this section has a note stating that the returned contract address must be inserted into the dApp but the section to do it https://taqueria.io/docs/scaffolds/taco-shop/#insert-the-contract-address-optional is listed optional. We should make this mandatory and put the two sections together
- https://taqueria.io/docs/scaffolds/taco-shop/#originate-to-the-testnet has a section on faucet files. Will need to be updated to reflect what we are moving to instead of faucet files
- Considering we originate to a testnet in this scaffold the test section seems unnecessary unless we have tests that are related to the taco shop
Quickstart project:
- No step to get user into directory, needs a `cd quickstart-project`
- Table specifies automated tests but the jest plugin is not installed, should be removed
- Requirements section should be moved up and use the format of other pages
- https://taqueria.io/docs/scaffolds/quickstart/#requirements has docker desktop listed but that is only for windows environments. We should probably have a note that it is only required for windows users
- There is a note in the requirements for not scaffolding from the vscode extension. That may no longer apply
- https://taqueria.io/docs/scaffolds/quickstart/#use-of-nodejs bad formatting for `/app`
- https://taqueria.io/docs/scaffolds/quickstart/#app-specific-settings should update the actual json files here, some differences are there
NFT Scaffold:
- No requirements section for what you need for the scaffold
- https://taqueria.io/docs/scaffolds/nft-scaffold/#project-setup should have a step before step 6 which gets user back to main project directory. Right now the start taqueria:local script won't work
Hey @alexzbusko, thanks for putting these findings together!
Here's my thoughts on the points above:
Overall structure notes: Yes let's standardize this!
General home page: I hadn't noticed the colour change before but it's something we should fix
Introduction Page:, Quickstart page:, Scaffold basics:, Taco shop:, Nft Scaffold: I agree with all your suggestions!
Quickstart project Can be removed
VSCode extension overview:
- "More details on how to isntall Taqueria VS Code Extension"
- Expand the section for overview "The extension consist if next items:"
- Image for extension use light mode instead of dark mode. The installation page has dark mode so we should pick one and then keep it consistent
- Again note states command palette for VSCode extension, which isn't mentioned on this page at all. If we want to focus on the UI then we should make docs default to that and then have a section at the end for the command palette functionality
- Better wording for "After new project created or the extension is opened on existing taqueria project it will show up next sections:"
-- Should also go through the steps of initializing a project since that is the base case for a lot of users
- https://taqueria.io/docs/vs-code-extension/overview/#each-section-can-be-hidden-and-unhidden-more-details-can-be-found-on-the-picture can be removed, we shouldn't be explaining VScode functionality to users
- https://taqueria.io/docs/vs-code-extension/overview/#contracts-section Should we continue with the contract registry language if it isn't relevant anymore?
- https://taqueria.io/docs/vs-code-extension/overview/#artifacts-section should expand overview
- No icon for deploying a contract in the image for https://taqueria.io/docs/vs-code-extension/overview/#artifacts-section
- "If there are multiple environments created into config.json Taqueria VS Code extention will pop-up dialog box to select an environment." does it do this if there is only a single environment as well?
Plugins Section:
- Should have table updated with metadata plugin since it's on the sidebar
- "During installation, NPM packages for the plugin are downloaded into the project folder and the plugin is registered in ./.taq/config.json" should probably lose the `./`
- Description for tezos client plugin could possibly link out to the https://tezos.gitlab.io/introduction/howtouse.html#client page to give users more information
- In general tables for plugin tasks have headings that are lowercase but other tables on the website has capitalized words for column headings. We should standardize on capitalized headings
- Should we standardize the plugin architecture on all plugin pages to just have "This is a plugin developed for Taqueria built on NodeJS using the Taqueria Node SDK and distributed via NPM"?
Archetype plugin:
- Need to update compile command to specify that you need to name a contract to compile and it will not try to compile all
- " The Archetype plugin also exposes a contract template via the taq create archetypeContract <contractName> task. This task will create a new Archetype contract in the contracts directory, insert archetype contract boilerplate, and register the contract with Taqueria" - Need to update the spelling of `archetype` and remove part about registration of the contract
- https://taqueria.io/docs/plugins/plugin-archetype/#running-the-compile-task needs to be rewritten for the contract registry and the compile all info
- Caution note has "SmartPY" when it should be "SmartPy". Spelling of "Archetype" instead of "archetype" as well
- https://taqueria.io/docs/plugins/plugin-archetype/#tasks registry wording and all contracts needs to be removed
- https://taqueria.io/docs/plugins/plugin-archetype/#the-create-archetypecontract-task has example "taq create archetypeContract <contractName>" but table has " 'create archetypeContract [sourceFile]", we should make consistent and add closing single quote
Contract Types plugin:
- configuration section to lose `./`
- In general should call out if no output directory is specified then it will output to the `/types` directory
Flextesa plugin:
- https://taqueria.io/docs/plugins/plugin-flextesa/#overview update to be more than just VSCode command palette
- "You can configure the Tezos protocol for each sandbox to test against current, and future network upgrades" don't know if this is true, Michael W I think told me that we are stuck on a specific version until we change it outselves
- "Accounts and balances will be re-initialized each time they are started" update to say when a sandbox is started
- remove "Contracts must be registered in the Taqueria contract registry prior to originating"
- https://taqueria.io/docs/plugins/plugin-flextesa/#cli-commands should have more than command palette and remove `./`
- https://taqueria.io/docs/plugins/plugin-flextesa/#the-default-sandbox-configuration update to Kathmandu protocol
- https://taqueria.io/docs/plugins/plugin-flextesa/#adding-a-new-sandbox-configuration "sandboxConfigObject" should probably be formatted as code for explanation
- https://taqueria.io/docs/plugins/plugin-flextesa/#accounts-1 update format to be "3_000_000_000"
IPFS Plugin:
- Update requirements to specify a JWT in a .env file in the project
- https://taqueria.io/docs/plugins/plugin-ipfs-pinata/#usage should have spaces removed from example command arguments
Metadata Plugin:
- Should we link to TZIP-16 since it is called out a few times?
- Spacing in arguments again
- "./artifacts" directory should be "artifacts"
- "taq generate-metadata" should have consistent arguments in our docs
- extra taq in command for https://taqueria.io/docs/plugins/plugin-metadata/#task-properties-1
- https://taqueria.io/docs/plugins/plugin-metadata/#generating-project-metadata missing '/' and should be formatted as code
Jest Plugin:
- "taq test [partitionName]`" remove backtick
- Expand on "Create tests in that folder tests/example.spec.ts"
- https://taqueria.io/docs/plugins/plugin-jest/#jest-configuration remove `./` from instructions
- Jest configuration has "The default root directory for Jest can be overridden by setting "jestTestsRootDir" in taqueria.config.js" which should probably be "jest.config.js"
Ligo Plugin:
- usage should specify that a filename is required. Should be similar to archetype: "taq compile [contractName]"
- https://taqueria.io/docs/plugins/plugin-ligo/#basic-description should have no slash in the `/artifacts` folder
- https://taqueria.io/docs/plugins/plugin-ligo/#the-taq-test-task the description should use more definitive language than "output suggests a pass or failure"
- https://taqueria.io/docs/plugins/plugin-ligo/#template-creation remove talk about registering the contract
- https://taqueria.io/docs/plugins/plugin-ligo/#plugin-architecture copy paste error says Archetype
SmartPy Plugin:
- Top level description should include file extensions to be consistent with other compiling plugins
- Requirements should include a link to smartpy installation instead of having it on a separate line
- https://taqueria.io/docs/plugins/plugin-smartpy/#usage should specify that a filename is required. Should be similar to archetype: "taq compile [contractName]"
-- Should specify that only the called contract will be compiled instead of all
- Overall this page needs to be updated to the more recent formatting
Taquito Plugin:
- https://taqueria.io/docs/plugins/plugin-taquito/#options should update to KathmanduNet now. Also use --env if it is the one mentioned
- https://taqueria.io/docs/plugins/plugin-taquito/#examples specifies that trasnfer and call are the same. call should be an alias then and the docs in the CLI and website should reflect that
-
Tezos-client plugin:
- https://taqueria.io/docs/plugins/plugin-tezos-client/ should we update protocol to Kathmandu now?
- https://taqueria.io/docs/plugins/plugin-tezos-client/#basic-description should we update this to be "valid/invalid" wording? I think so
Task reference:
generate types:
- https://taqueria.io/docs/tasks/generate-types/#overview - Should update to match plugin page for type safety
init:
- lose starting `./` for directories
- note should link to the taq scaffold task
- https://taqueria.io/docs/tasks/init/#task-details should use single quote instead of backtick
Install:
- needs to have metadata-plugin added to table
List accounts:
- Should have square brackets to match flextesa plugin page or vice versa. Check with Houston
opt-out:
- Last description should be "disables sharing" instead of "enables"
Originate:
- Page should just be "refer to the following"
Publish:
- Pinata Link is broken and goes to 404
Generate-metadata:
- https://taqueria.io/docs/tasks/generate-metadata/#overview proofreading
- first command needs generate-metadata
- task name for project metadata should have dashes
- Overall just proofreading for the tables
scaffold task:
- "taq`ified" should use single quote
Simulate:
- Just make it 1 option
Start Sandbox:
- Use yellow regular link like in other places for sandbox configuration docs
- sandboxName isn't required and we should update to reflect this
Test:
- Change regex expression to regular expression
Transfer/Typecheck:
- Use singular link language
Uninstall:
- Needs meta-data added to table
Features:
Github Action:
- Proofreading on overview section
- Need to update version info in the example code
Templates:
- Remove contract registry wording
Configurations section:
Testnet Configuration:
- https://taqueria.io/docs/config/networks/#configuration link to ghostnet is broken
- https://taqueria.io/docs/config/networks/#environment-configuration "ghost" should be ghostnet
Account configuration:
- Update after starting sandbox config.json to have all accounts
- Possibly can remove the default account section
- Infor for the first point here can be found in the Sandbox config page
Sandbox Configuration:
- remove "./"
- sandboxConfigObject should be "sandboxConfig object"
Environment Configuration:
- https://taqueria.io/docs/config/environments/#the-default-environment should have local as a sandbox in there
- Remove note for storage specified in the config.json file since it no longer applies, all storage should be gone since it no longer applies in config.json
Taqueria Development Section:
- Roadmap and releases should be updated to reflect current stuff
Looks great @alexzbusko! Let's go ahead and make those changes
I can help with the roadmap and release sections
Done
π Epic|Feature Link
No response
π₯ Definition of Done
β To Do
No response
π Scope
ποΈ In Scope:
Confirming all tasks documented have the correct and complete set of parameters and options documented
π ββοΈ Out of Scope:
π§° Work Description
Taqueria has been undergoing rapid development and changes over the past couple of months. As such, the Docusaurus documentation is now out of date in places and needs to be reviewed and updated so it matches what our users will see with the current release, and correctly get's them through any processes with accurate code snippets and confirming that all the commands and steps listed work as expected
This is also a huge opportunity for additional manual testing of Taqueria which may uncover additional bugs or opportunities for improvement. These should be logged!
βοΈ Acceptance Criteria
π Documentation:
π Review / Approvals:
π’ Test Plan
No response
π Release Notes
No response
π¦ Sizing
No response
Code of Conduct