TezosTaqueria / taqueria

*BETA* Taqueria provides a seamless development workflow to easily build, test and deploy your Tezos applications.
https://taqueria.io
Apache License 2.0
64 stars 20 forks source link

๐Ÿ› Bug โžพ Cannot call compile parameters when there is only 1 entrypoint declared #1903

Closed zamrokk closed 1 year ago

zamrokk commented 1 year ago

๐Ÿšฅ Status (Internal Taqueria Team Use Only)

๐Ÿ†˜ What happened?

Running dapp-1 training , when I try to compile with parameter and new ligo syntax @entry, there is an issue while there is 1 unique entrypoint. If I add a secondary one, no problem. I think it is linked to the fact that in Michelson, when there is only 1 entrypoint, the default naming is overriden to Default. Not first time we see this hack :/

image

image

image

๐Ÿ†˜ Steps to Reproduce?

Run dapp-1 training here (https://github.com/marigold-dev/training-dapp-1)

try to compile when the parameterList is set before the step of the taq simulate

๐Ÿชต Relevant log output

No response

๐Ÿ˜ How impactful is this bug?

๐Ÿค” Notable but managable

โฑ๏ธ Prevalance

No response

๐Ÿ’ป Operating System

Windows -> WSL

๐Ÿ•ธ๏ธ System Architecture

None

๐ŸŒฎ Taqueria Version

v0.39.0

๐ŸŒฟ Node.js Version

No response

โ˜Ž๏ธ Contact Details

No response

Code of Conduct

mweichert commented 1 year ago

Reproduced. I've reached out to Laurent to see if he can help us figure this one out.

mweichert commented 1 year ago

Conversation with LIGO team here: https://tezos-dev.slack.com/archives/CFX0B8Q3X/p1693342733039869

mweichert commented 1 year ago

It looks like this is currently expected behavior in LIGO but they are adjusting the implementation so that a single @entry will work as expected with the constructor in place.

zamrokk commented 12 months ago

Hi @mweichert

Can we reopen the ticket ? I don't have a working version of it with taq

If I use ligo compile parameter ./contracts/pokeGame.jsligo "[]"

It returns Unit, what is expected

But with taq, nothing passes

image

image

any idea ?

zamrokk commented 11 months ago

@mweichert

Some changes are coming to fix this

https://gitlab.com/ligolang/ligo/-/merge_requests/2898#eff41cb129b250b5d2e6507556656d455f615747

We reintroduce the default main entrypoint in case of contract single entrypoint declaration