TfT-02 / Duel

Bukkit plugin which allows players to duel each other in a intuitive way - without using any commands.
5 stars 8 forks source link

Make players in a Duel Can't see other players. #34

Open IlPicasso opened 10 years ago

IlPicasso commented 10 years ago

Make players in a Duel Can't see other players.

I have a PvPKit Server, I wanted to add a /duel feature however I have problems with

    # Should Duel prevent player versus player combat outside duels?
    Prevent_PVP: true

    # Override PVP prevention from other plugins?
    Override_PVP: false

If I set true Override PVP Prevention from other plugins players can't attack others only in duel

If i #Should Duel prevent player versus player combat outside duels false players will be able to attack everyone, incluiding while they are in duel

While adding this feature none of those features will be necessary

roblikescake commented 10 years ago

I don't understand what you're asking for.

I believe you are asking for a new feature where players who are dueling each other cannot see other players, ie: they are invisible during duel.

I believe you are then going on saying there's a bug in the override pvp function. You are saying that if set to true, players can only attack eachother in duel? If that's the case, are the plugins you use set to allow pvp? As I recall, Duel doesn't stop players from attacking one another, only allows them to if the override pvp option is true.

The Prevent PVP option being true means PVP outside of a duel is not possible. If it is false, it will allow players not dueling to pvp, if another plugin isn't blocking it, I believe.

IlPicasso commented 10 years ago

My mistake Rob, what I wanted was to suggest a feature, I flagged this wrongly

roblikescake commented 10 years ago

So you are requesting the invisible players while dueling addition?

IlPicasso commented 10 years ago

Well it would be something like this You: /duel (player) Opponent: /duel accept

(Countdown) (You and your opponent become invisible for everyone , you can only see the opponent and yourself) (Both players Start Dueling) (Die, Respawn on spawn)

Sorry if I can not make me understand. I am not a native english speaker

TfT-02 commented 10 years ago

Oh hey, that is quite a cool feature!

I'd like to iron out some of the bugs first though, but once that is done - I'll be sure to look into this.

TfT-02 commented 10 years ago

Oh and

While adding this feature none of those features will be necessary

This isn't true, because Override_PVP: means that Duel will override PVP prevention from other plugins, like WorldGuard or Factions.

Prevent_PVP: is an option to enable/disable PVP prevention by Duel, for players who are not dueling.

IlPicasso commented 10 years ago

I am glad you like my suggestion.

roblikescake commented 10 years ago

@TfT-02 I like the idea of those whom are not dueling becoming invisible, however the two dueler's becoming invisible to everyone else? I'm not too sure on that.

IlPicasso commented 10 years ago

@roblikescake You could enable/disable that on config, if its possible of course.

In my case it would be better becoming invisible to everyone else since I plan running this into a PvPKit server, meaning that in the map there will be many players around so the players that are not dueling wont try to hit the players that are dueling.

TfT-02 commented 10 years ago

Yeah, was thinking of making that configurable @roblikescake

roblikescake commented 10 years ago

@TfT-02 Mkay, wanna use our own invisible coding, or hook into VanishNoPacket?

roblikescake commented 10 years ago

@TfT-02, I began work on this. See development branch.