search

TfTHacker / obsidian42-strange-new-worlds

Revealing the strange new world of connected thoughts in your vault.
https://tfthacker.com/SNW
MIT License
432 stars 13 forks source link

Ghost link references cause incorrect reference behavior in Reading Mode #133

Closed jjaychen1e closed 4 months ago

jjaychen1e commented 5 months ago

When a note includes at least one ghost link, the reference count is incorrect in Reading Mode (but is correct in Editing Mode).

In this case, let define the first reference as r1, all rest references will show the same reference count as r1.count, and the popover window also shows the information about r1.

TfTHacker commented 4 months ago

Thank you for reporting this issue. I recently rewrote the SNW indexing engine, and I could not reproduce the problem during my testing. So, I'm hoping that it has been fixed. I plan to release the beta version as 2.0.0 soon, and I hope you will all be able to test it and report on whether it is working.

If you want to test it now, please install the plugin using BRAT. Version 1.2.7 is the beta version and includes the intended fixes.

seomwan commented 4 months ago

@TfTHacker I think maybe the references need to have dots . in their names, so for example:

Those are correct for both Live and Source Mode. This is on SNW 2.0.2

seomwan commented 4 months ago

Btw, I think counts should not be displayed in Source mode, but that's probably another issue (mentioned because it may simplify implementation of this)

TfTHacker commented 4 months ago

This is a good catch. I was able to reproduce the issue. Actually it revealed that many ghost file scenarios were not handled correctly. I hope to release 2.0.3 today, please feel free to test that and see if it is better.

Regarding source mode, please open a FR if you think that would be a good idea.