[Bug] `ABI` Command vs `CC` Command (Release 0.7.0)

TfTHacker / obsidian42-text-transporter

Text Transporter - advanced text management for Obsidian.

https://tfthacker.com/transporter

MIT License

205 stars 10 forks source link

[Bug] `ABI` Command vs `CC` Command (Release 0.7.0) #12

Closed FelipeRearden closed 3 years ago

FelipeRearden commented 3 years ago

Hello @TfTHacker !!!

I think I find a bug: the ABI command have the same result as CC

If I understood correctly the definition of CC and ABI:

CC -> ![[Filename#^BlockRef]] (embed link)
ABI -> [[Filename#^BlockRef]] (not embed link)

On 0.7.0 we have CC and ABI as ![[Filename#BlockRef]] for both commands.

Sorry if I understood incorrectly the commands.

Have a great day!

TfTHacker commented 3 years ago

You are right. These commands are redundant, basically doing the same thing. I will reduce it to one command in the next release. Thank you for the feedback on this.

FelipeRearden commented 3 years ago

@TfTHacker,

We need these two commands working as I described above.

One for embed links CC ![[Filename#^BlockRef]]
Another for block references ABI [[Filename#^BlockRef]]

And one for block references with alias CA [[filename#^blockref|alias]]

Please don't kill any of then :)

At this moment we are talking I'm testing all Transporter Commands and I will bring new insights about all combinations :)

TfTHacker commented 3 years ago

For me they are both doing block embeds. So you are suggestion block embed and just block ref?

FelipeRearden commented 3 years ago

Yes :)

One for block embed CC ![[Filename#^BlockRef]] Another for block ref ABI [[Filename#^BlockRef]]

FelipeRearden commented 3 years ago

Hello @TfTHacker

I’m starting my tests on 0.8 right now !!!

I have a question:

Consolidated commands CC and ABI into one. (Thanks FelipeRearden ). Will expand on this command as per your issue.

I’m not a native English speaker and I’m sorry if I didn’t understood correctly -> is ABI coming back in the next/future release as a new feature: [[Filename#^BlockRef]]?

CC CA and ABI closes the types of [[ ]] references possible in Obsidian;
and I’m asking because I’m updating the text I’m writing about Transporter Commands (that I will post as a new Discussion in the next ours) and ABI has a role the commands that I will suggest to you and our friends.

Have a great day!

TfTHacker commented 3 years ago

Basically the old copy as block reference and add block reference were doing the same thing. Just the first command only worked on one block, while the other did multiple blocks. So it was redundant. They both insert block embeds ( using the ! In the front). This command supports not just block embeds of paragraphs, but block embeds of headings. So lets day you highlight this text:

# heading 1
Paragraph 1

Paragraph 2

It will be converted too

# heading 1
Paragraph 1 ^ab3affa

Paragraph 2 ^zadfa9a

Amd the clipboard will now contain:n

![[file name#heading 1]] ![[file name#^ab3affa]] ![[file name#^zadfa9a]]

History: I wrote the first command in the beginning, then a second command to do multiple paragraphs. I didn’t realize they are basically doing the same thing. This is why I reduced it to one command. But they always output block embeds with !, not block references without.

TfTHacker commented 3 years ago

And thank you for your help :-)

FelipeRearden commented 3 years ago

Thanks for you reply!

I will update my suggestion.