search

Tfarcenim / AE2-Extras

The Unlicense
2 stars 3 forks source link

1m and 4m Fluid Storage does not Work #13

Open Gillios opened 3 years ago

Gillios commented 3 years ago

Hey, the 1m and 4m Fluid Storage Cell´s for AE2 are not working. 256k is okay and 16m is also okay.

ClintRajaniemi commented 3 years ago

Something I noticed this morning. Thought I was going crazy. When I pop the fluid storage component from the ME Storage Housing (shift + right-click), it's changing to the equivalent sized ME Storage Component. This includes for the 16m fluid storage.

Mod pack: ATM6 1.7.11 Minecraft version: 1.16.5 AE2 Extras version: 1.3

Tfarcenim commented 3 years ago

Found the problem, it's actually an AE2 bug that affects all fluid drives above 256k due to integer overflow (the only reason the 16M is able to accept fluids at all is because the integer overflowed so far that it happens to be positive, but if filled enough you will find that it can't support the full 16M claimed, not unlike those fake 512GB thumb drives that were re-flashed 8GB.)

As for this issue, I will be forwarding a report to AE2 so they can fix the issue on their end. In the meantime, I'll add a patch for AE2 Extras items so that they will no longer be affected by integer overflow.

Something I noticed this morning. Thought I was going crazy. When I pop the fluid storage component from the ME Storage Housing (shift + right-click), it's changing to the equivalent sized ME Storage Component.

That also has been fixed.

Tfarcenim commented 3 years ago

Reporting is done, track https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/5427

Tfarcenim commented 3 years ago

The mystery deepens, it looks like a proper fix is hinted at in https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/4352 , but it will be neither quick nor easy. For now I've made the patch that should hopefully work until I am able to draft up a proper fix (and hopefully nobody's fluids will go missing.) In the off chance that the fluid cells above 256k are still bugged out, I'm leaving this open.