search

Tfarcenim / CIT-Reforged

CIT mod ported to forge
2 stars 0 forks source link

Wool/Colored block based CIT's Don't Work #5

Closed FatherPigeon closed 10 months ago

FatherPigeon commented 10 months ago

I'm having an issue getting wool/colored blocks-based CITS to work for me. The CIT pack itself works fine, but there are some models that use wool for certain colors and they don't work Here's an example of my issue: 2023-11-19_02 59 15

Tfarcenim commented 10 months ago

3 things: 1) Do you have a copy of the CIT pack? 2) Does it work as intended on Optifine? 3) Does it work as intended on CIT Resewn (fabric)?

FatherPigeon commented 10 months ago

Hi, yes I have a copy of the pack. It's worked on both Fabiric and Optifine. It has also worked on previous versions of Minecraft forge with a cit mod before

Tfarcenim commented 10 months ago

Could you send it so I can see what's wrong?

FatherPigeon commented 10 months ago

of course! Here's the file equestrian-cit-v4-0.zip

Tfarcenim commented 10 months ago

The issue is broken resourcelocations, did you check the log?

Minecraft throws an error when it encounters capitals or spaces and while optifine and the older CIT mods patch it out, I'm not doing it because

A: it slows down the game

B: it hides more serious errors from other mods

C: it's a pain in the ass to patch and maintain for no benefit when resourcepack makers can fix what's been broken since 1.13

Here's a snippet

[01:46:58] [Worker-Main-10/ERROR] [CITResewn/]: {citresewn} Couldn't load CIT: JsonParseException: block/Blanket Rack Colors/blanket_rack_orange is not valid resource location in file/equestrian-cit-v4-0 -> minecraft:optifine/cit/blanket_rack_orange.properties [01:46:58] [Worker-Main-10/ERROR] [CITResewn/]: {citresewn} Couldn't load CIT: JsonParseException: block/Grooming Box Colors/grooming_box_orange is not valid resource location in file/equestrian-cit-v4-0 -> minecraft:optifine/cit/grooming_box_orange.properties [01:46:58] [Worker-Main-10/ERROR] [CITResewn/]: {citresewn} Couldn't load CIT: JsonParseException: block/Jolly Ball Colors/jolly_ball_orange is not valid resource location in file/equestrian-cit-v4-0 -> minecraft:optifine/cit/jolly_ball_orange.properties

Tfarcenim commented 10 months ago

The solution is to fix the paths so it no longer throws an error, it is not a bug in the mod