search

Tfarcenim / Dank-Storage

dank storage
17 stars 20 forks source link

1.18 porting effort #156

Closed madkat closed 1 year ago

madkat commented 2 years ago

Let me just start with: I really appreciate your work on this mod. It's such a QoL boost when mining and it is a big staple in my group in any modded MC game. Playing ATM7 on 1.18.1 without Dank Storage is awful!

I started getting an environment setup this week to help with the porting effort. After reading some other issues, it sounds like you are in the midst of another significant code change. Is that for changing over to the official mappings or something else?

If you have a work-in-progress branch, I'd be happy to chip in some time on whatever is outstanding.

Tfarcenim commented 2 years ago

Don't port this version, the mod's been rewritten (again) for 1.18+, look here if you want to help although I'm not releasing any builds until 39.1.0+

https://github.com/Tfarcenim/DankStorageFabric

Tfarcenim commented 2 years ago

The names are already in mojang so all that really needs to be done is converting the fabric api stuff into the forge equivalent, I'm preoccupied with other matters at this moment, otherwise I would do it myself.

madkat commented 2 years ago

Made some progress over the weekend retargeting the DankStorageFabric 1.18.x branch to forge. It is going to take some experimentation on my end to understand some of the differences.

Will this work eventually go into DankStorageFabric or Dank-Storage? I could do a 1.18.x-forge branch on the former, or just a 1.18.x branch on the latter.

Tfarcenim commented 2 years ago

I made a 1.18 branch here for you to PR against.

madkat commented 2 years ago

Great, thanks!

Tfarcenim commented 1 year ago

this is no longer needed