Tfarcenim / Dank-Storage

dank storage
15 stars 15 forks source link

[1.20.1-8] Each new game start ID assignment starts with ID 0 #234

Open Garonne opened 4 months ago

Garonne commented 4 months ago

First of all: Danks already assigned an ID work fine.

Whenever I open a new dank (ID: -1) after I restart my local minecraft game my danks are assigned IDs starting 0, 1, etc... Despite those IDs being already assigned to other danks. This leads to frequencies being involuntary upgraded to higher dank levels (if the new dank is of a higher tier than the original one).

Current possible solve: When a new ID needs to be assigned, I first take a Tier 1 dank and assign it to a "new" frequency (ID: 0)... Use /dankstorage reset_frequency to reset it back to -1, and repeat, until the Tier 1 dank is assigned the current highest frequency (or the first new frequency). THEN I take the first new dank and assign it the new frequency to unlock a new frequency.

Possible improvements: It would be nice if there was a posibility to "open" a dank with frequency -1 without assigning it a real frequency and be able to manually assign it a new frequency. Currently, it's not possible to assign danks to frequencies which are not yet "opened" by the above method. Being able to assign frequencies currently not used would be a great help. Being able to assign a frequency using a command would also help.

Being able to set the "next unused frequency" by command would also be tremendously useful.

My request: [New Command] Set next free frequency X. [New Command] Assign Frequency X, Tier Y to current dank. Unlocking frequency if needed. (if not already working)

Edit: Assigning Tier and Frequency to a dank is already possible via command Set_Tier. Will it unlock new frequencies? Ok... No matter which frequency I try, set_tier replies: "frequency doesn't exist", even if I have a dank with said frequency in hand.

Tfarcenim commented 4 months ago

Whenever I open a new dank (ID: -1) after I restart my local minecraft game my danks are assigned IDs starting 0, 1, etc... Despite those IDs being already assigned to other danks. This leads to frequencies being involuntary upgraded to higher dank levels (if the new dank is of a higher tier than the original one).

Weird, any reproduction steps? I tried doing what you said and it assigns fine.

It would be nice if there was a posibility to "open" a dank with frequency -1 without assigning it a real frequency and be able to manually assign it a new frequency.

Noted, I will add it as a feature

Commands are currently disabled as they were only meant for fixing worlds back in 1.18 - 1.19 and I would rather find a proper fix.

Garonne commented 4 months ago

Weird, any reproduction steps? I tried doing what you said and it assigns fine.

Well... As posted reproduction is apparently quite easy... Play MineCraft (All The Forge 10), add DankStorage, assign some Danks, unload the game (Main Menu is enough), restart/reload game, assign additional Danks. New Danks are assigned starting from ID 0 again, though they should not.

Maybe some Mod incompatibility, though I don't seem to be the only one affected...

Actually issue #233 and #226 seem to have the same issue... Same problem, when switching to [1.20.1-6] or [1.20.1-5]

Is there some easy way to dump a complete list of mods? If it's an incompatibility, maybe I and the other two people can narrow it down by comparing our mod lists? I know, "All The Forge 10" already has a huge list of Mods... (I got 247 mods right now...)

Here we go:

[... - updated list in next post]

I'll try to eliminate some mods to reduce the list...

Garonne commented 4 months ago

Issue persists in a fresh install of "All The Mods 10" with no optional files only Dank Storage added... So one of these mods must cause the conflict (in case it's a mod conflict).