Danks Upgrading an existing dank using a crafting table and placing items in the last row deletes them on the server's end

Tfarcenim / DankStorageFabric

Creative Commons Zero v1.0 Universal

11 stars 9 forks source link

Danks Upgrading an existing dank using a crafting table and placing items in the last row deletes them on the server's end #52

Closed SamHammie closed 2 years ago

SamHammie commented 2 years ago

I was playing AoF5 1.18.1 and when I made a dank 2 and put some items in the second row they got deleted. I had already used it as a dank 1 and it saved the contents but never considered the second row.

The mod version is 3.0.1 for 1.18.

Edit: As it turns out, it happens for any upgrade done in the crafting table after a dank is assigned an ID, but if it's upgraded while it has an ID of 0 then the new rows work fine until upgrading it again.

Tfarcenim commented 2 years ago

How was the dank upgraded, crafting table or upgrade card?

SamHammie commented 2 years ago

How was the dank upgraded, crafting table or upgrade card?

Crafting table

Tfarcenim commented 2 years ago

I forgot that Minecraft treats an empty nbt value as 0, so I will have to ban it from being used as an id. I will get a fix later tonight, hopefully it doesn't break too much.

Tfarcenim commented 2 years ago

Shouldn't be possible anymore