Tfarcenim / FabricFastBench

Creative Commons Zero v1.0 Universal
7 stars 4 forks source link

Active in-inventory autocrafters such as Botania's Manufactory Halo blanks output slot in crafting tables #21

Open Ampflower opened 1 year ago

Ampflower commented 1 year ago

Minimal mods found:

Items/blocks required:

Notes:

Steps to reproduce

Additional notes:

Ampflower commented 1 year ago

It appears to be caused by the manufactory halo constantly hitting the crafting path regardless of if the GUI is open and that there's valid recipes; using Gadget to examine packets show that there's a constant stream of the custom packet fastbench:sync_recipe.

Ampflower commented 1 year ago

Looking at the menu field on the CraftingInventory via the debugger, there is a way to tell by the access field and the container ID being less than 0.

Ampflower commented 1 year ago

By checking the container ID, it does prevent the blanking out bug. Tho, removing the custom sync packet and letting the results slot seems to work fine in the mod on the client does seem to behave correctly, regardless of having this mod on the client, contrary to what has been said in #8. Although, this may be because logic has changed since then in Minecraft that manages to make this work when this mod originally would have broken it.