search

Tfarcenim / FabricFastBench

Creative Commons Zero v1.0 Universal
7 stars 4 forks source link

Update to 1.19.2 and fix various bugs #22

Open Ampflower opened 1 year ago

Ampflower commented 1 year ago

A few updates to FastBench to bring it up to speed (not really required, as it worked as is on 1.19.2), fix some odd issues, and try to see if it's possible to not require the client component of this mod, rendering it entirely server-side.

Ampflower commented 1 year ago

It appears that there's still some bad interaction with the manufactory halo, will take the time to investigate it some more.

FastBench is somehow consistently hitting the slow route with the manufactory halo failing to internally place items?

Ampflower commented 1 year ago

Found that it was because Vanilla called access to evaluate it, which normally is populated by a crafting table, but not by Botania's manufactory halos or any other auto-crafters that do a fixed recipe lookup.

This has been changed to also use access as a gate to only evaluate it when there's actually a player looking at the inventory, and to not otherwise.

There's still some potential optimisation left with having clear not send slot updates or attempt to evaluate recipes 9 times.

Ampflower commented 1 year ago

Perhaps calling the method to stop matrix updates on ServerPlaceRecipe#clearGrid(boolean) would be a good start? Then letting it do matrix updates after the final clear call.

Ampflower commented 1 year ago

And it appears I managed to accidentally deoptimise the packet spam, I wonder if the attempt to smartly optimise clearGrid did something wrong.

Ampflower commented 1 year ago

Seems no more unexpected issues are coming up. Is working fine in a modded environment without tanking the TPS in unexpected ways or spamming packets, while still retaining vanilla features.

EGOIST1372 commented 1 year ago

@Tfarcenim any news on merging this? thanks in advance <3

MJRamon commented 1 year ago

Can you please merge and release 1.19.2? @Tfarcenim

TheStaticVoid commented 1 year ago

This project seems unmaintained for some time. The project is CC0 licensed meaning that a forked release could be made to provide updates to newer versions. @Ampflower have you had any thoughts on re-releasing and becoming the maintainer for this mod as you seem to have interest in fixing it up?

Ampflower commented 1 year ago

This project seems unmaintained for some time. The project is CC0 licensed meaning that a forked release could be made to provide updates to newer versions. @Ampflower have you had any thoughts on re-releasing and becoming the maintainer for this mod as you seem to have interest in fixing it up?

I'll take a look into it; shouldn't be much but I'll need a new name for the mod

EGOIST1372 commented 1 year ago

Few ideas for name Quickbench Immediately benches Bench tweaks Table tweaks Fast Workstations (if you like to combine both fast bench and fast furnace together) Also the word fast in fast Workstation can be changed to quick/Immediately/tweaks as well And thanks for your help ❤️

On Tue, Sep 5, 2023, 22:07 Ampflower @.***> wrote:

This project seems unmaintained for some time. The project is CC0 licensed meaning that a forked release could be made to provide updates to newer versions. @Ampflower https://github.com/Ampflower have you had any thoughts on re-releasing and becoming the maintainer for this mod as you seem to have interest in fixing it up?

I'll take a look into it; shouldn't be much but I'll need a new name for the mod

— Reply to this email directly, view it on GitHub https://github.com/Tfarcenim/FabricFastBench/pull/22#issuecomment-1707135644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUULT66LF2KFYNNWYHNNFNDXY5WPVANCNFSM6AAAAAASLXUX54 . You are receiving this because you commented.Message ID: @.***>

TheStaticVoid commented 1 year ago

This project seems unmaintained for some time. The project is CC0 licensed meaning that a forked release could be made to provide updates to newer versions. @Ampflower have you had any thoughts on re-releasing and becoming the maintainer for this mod as you seem to have interest in fixing it up?

I'll take a look into it; shouldn't be much but I'll need a new name for the mod

FastBench: Even Faster

Ampflower commented 1 year ago

Hm, looking around at the based off of codebase, https://github.com/Shadows-of-Fire/FastWorkbench, it appears that it's supposed to be MIT-licensed.

I'd still consider that safe although I'd need to try to trace out licensing in such a case regardless.

@Tfarcenim Curious, did you mean to license your own changes and adaptation as CC0 or MIT? Mainly so I know what to credit as.

Ampflower commented 1 year ago

Okay, consulting the codebase a bit and comparing with Shadows of Fire's, I can tell a fair amount should've been under the MIT license, so I shall assume it was intended to be that and that CC0 was a left over from the template.

Ampflower commented 1 year ago

I suppose that's one way to close a PR lol; renamed the branch which technically deletes it