Tfarcenim / FabricFastBench

Creative Commons Zero v1.0 Universal
7 stars 4 forks source link

With the Stacc mod, crafting tens of millions of items at once can cause the server to freeze / crash. #6

Closed James103 closed 3 years ago

James103 commented 4 years ago

Minecraft 1.16.1 Stacc 1.16.1 4 FastBench 2.3 See Devan-Kerman/Stacc#6

When you craft millions of items at once, both the client and server will freeze for at least a few seconds. Attempting to craft more than a hundred million items at once can crash the server due to the watchdog.

This is because even when shift-clicking, it only performs one craft per loop (doing upwards of millions of loops at once) instead of doing it all as much as possible in a single loop.

Tfarcenim commented 4 years ago

not a bug in fastbench but the limits of what can be done with vanilla crafting.

Devan-Kerman commented 4 years ago

iritat

Tfarcenim commented 4 years ago

no, but I think I can make it faster

Devan-Kerman commented 3 years ago

did u make it faster or did u give up

Tfarcenim commented 3 years ago

Stacc fixed this on their end.

Devan-Kerman commented 3 years ago

Wait did I, well kinda cus I just yote the mod but idk if that counts

Tfarcenim commented 3 years ago

Considering this is a vanilla issue and has nothing to do with fastbench at all, I don't know why it was reported here. it's like saying a fire extinguisher can't put out an exploding fireworks factory.

Tfarcenim commented 3 years ago

Stack sizes in crafting table are capped to like 50k I think so this doesn't happen again

Devan-Kerman commented 3 years ago

oh right, I did do that