Tfarcenim / crafting-station

crafting station
7 stars 21 forks source link

[1.19.2] Interaction with create 0.5 multiblock item vaults #87

Closed zaftnotameni closed 1 year ago

zaftnotameni commented 1 year ago

Noticed that placing the crafting station next to a multiblock vault, it "erases" the player inventory, at least visually.

Before placing the crafting station

2023-01-06_14 20 54

Crafting station open (see player inventory blank, but should have 2 picks)

2023-01-06_14 21 06

After closing the crafting station, see UI still shows the inventory as empty

2023-01-06_14 21 10

If i just click or shift click where the items where, they show up again, so they just become invisible in the player inventory.

Have not tested this on single player, but it is happening consistently on a server, no matter what I have in my inventory.

ClaudiusMinimus commented 1 year ago

zaftnotameni, thank you for posting this.

This is part of my pack, Create on a Potato PC: Sky Edition and the multiblock vault in question is from the mod, Create.

To provide a bit more information: Minecraft version: 1.19.2 Forge: 43.2.0 Crafting Station: 1.19.2-6 Create: 1.19.2-0.5.0.g

zaftnotameni, Please upload your latest.log and debug.log files as well - may help the developer solve this issue.

Thank you, CM

zaftnotameni commented 1 year ago

debug-during-problem.log latest-during-problem.log

good call on the logs, it seems like inventory sorter is probably partially to blame here

Tfarcenim commented 1 year ago

Seems like there is a desync between what the server is saying the slot count is and what the client is saying it has, I'm going to shove it into the default blockentity blacklist unless someone has a better fix that isn't hardcoding like I have to do with the vanilla double chest.

Tfarcenim commented 1 year ago

After looking at what the item vault does, I've decided to go ahead and blacklist it since it's a multiblock and the crafting station wasn't designed to be used with them.

ClaudiusMinimus commented 1 year ago

Thank you!

ClaudiusMinimus commented 1 year ago

I just updated and tested. It seems the crafting station still connects to the vault, but without the visual glitch. I can pull items manually from it, but the crafting station does not automatically pull for crafting. Is this what you intended? image