Tgxcorporation / skin.nebula

Nebula Skin for Kodi
Other
53 stars 18 forks source link

support for media flags whild using disc stubs #4

Closed Theodin closed 8 years ago

Theodin commented 8 years ago

First let me say I really like your skin! While using it, I discovered that dvds I have added to xbmc as disc stubs (http://kodi.wiki/view/Media_stubs) dont get the corresponding dvd icon. The film name/rating/year etc from the filmtitle.nfo show up but the dvd, codecs, rating etc (displayed below the cover on the left side in the list view are missing. Can you make Nebula display them too?

Tgxcorporation commented 8 years ago

Is there any skin which displays those infos with media stubs? I think this is not possible because how can a skin display an info if it's not available? A media stub is an empty file and does not carry the infos about resolution, audio code, channels, etc. It's only a name of an empty file. I think that if the skin does not display the corresponding media logos, it's normal.

Theodin commented 8 years ago

In the Confluence theme, its possible to get the DVD/Bluray by putting the folder with the stub (and others) into a folder called "DVD" so it can get the info from there. I will try to get some illustrating screenshots from my Kodi/Raspberry Pi and post them here to make my point clearer.

Theodin commented 8 years ago

Here are some screenshots: Bluray, DVD and VHS represent the folder name, which is conveniently displayed as a little symbol below the cover. But not if the stub (*.disc) is used.

bluray_file bluray_stub dvd_file dvd_stub vhs_file vhs_stub

The same goes for the age-rating (PG, R etc, I use the german ones) which is present in the nfo but not displayed on screen below the cover. Besides, would it be possible to somehow parse the age rating and just display the "12" instead of "germany:12"? Thanks for your time.

Tgxcorporation commented 8 years ago

Ok. I understand your point. Could you please post a screenshot of the same stub movie but using the Confluence skin?

Theodin commented 8 years ago

Here are the same movies (minus one where the screenshot somehow didnt work) displayed using the confluence skin:

vhs_stub vhs_file dvd_stub bluray_stub bluray_file

Tgxcorporation commented 8 years ago

Should be ok now with the latest commits on master and isengard branches.

Theodin commented 8 years ago

Wow youre fast! Thanks! I will try this. Do I have to wait for the next skin release to get the update or do I have to download the zip and update manually?

Tgxcorporation commented 8 years ago

Install from Github if you don't want to wait. No ETA for the official update at the moment.

Theodin commented 8 years ago

I tried installing it from the zip downloaded from github, but it said something about missing dependencies. Does the zip require the latest Kodi beta? I am using Isengard/Openelec.

Tgxcorporation commented 8 years ago

You need to install the script.skin.helper.service addon which is not yet in the Kodi repository:

https://github.com/marcelveldt/script.skin.helper.service

Theodin commented 8 years ago

Yes. And I had to change xbmc.gui to 5.3 to work with Helix. But now it works. Thanks for your fast answer!!!