ThKattanek / emu64

C64 Emulator
https://www.thorsten-kattanek.de/index.php/projekte/emu64
GNU General Public License v2.0
38 stars 6 forks source link

CI: Build with both gcc and clang #246

Closed Zirias closed 1 year ago

Zirias commented 1 year ago

After all the latest fixes, I was surprised emu64 didn't build any more locally on FreeBSD using clang, even without -Werror. The immediate cause were some unscoped bind() (std:: missing) calls that somehow seem to still resolve on Linux. But it also showed clang had some warnings that gcc didn't find.

So, to avoid as many issues as possible, I think it is best to test the build with both major compilers, gcc and clang. Of course this means CI builds take twice the time.

The PR includes fixes for the issues found by clang warnings.