search

ThaDafinser / UserAgentParser

UserAgent parsing done right
http://useragent.mkf.solutions/
MIT License
246 stars 47 forks source link

Run on the Trusty beta container #110

Closed photodude closed 7 years ago

photodude commented 7 years ago

This actually makes it so you are testing on Ubuntu 14.04 LTS Server and not the old Ubuntu 12.04.5 LTS precise containers.

ThaDafinser commented 7 years ago

Does this make any real significant difference for PHP currently?

photodude commented 7 years ago

The biggest change is it fixes the HHVM version to a valid latest (currently 3.18) rather than the EOL 3.6 version in precise.

ThaDafinser commented 7 years ago

@photodude is HHVM full PHP 7.0 compatible?

photodude commented 7 years ago

@ThaDafinser HHVM does have a php7 mode. Unfortunately, there is a major blocker that breaks composer https://github.com/facebook/hhvm/issues/7198 until that issue is fixed the php 7 mode is untestable on travis when projects use composer.

ThaDafinser commented 7 years ago

Sound like it's going to be a "dead cow" in the long run, if they don't catch up soon http://symfony.com/blog/symfony-4-end-of-hhvm-support

photodude commented 7 years ago

It somewhat is considering Laravel, Symfony, Doctrine, CakePHP, MongoDB, PHPUnit, Composer, Twig, Silex, and Swiftmailer, etc have all dropped support for HHVM. (that is something like 75% of the php market use has dropped support) They need to both fix the big issues and improve their support end when library devs report issues.

On the upside dropping support by those libraries doesn't prevent those projects from running via HHVM, it just means they are no longer testing and will only fix if someone submits a PR they won't read or fix issues on their end.

photodude commented 7 years ago

I'm closing out all of my PR's like this one considering that Laravel, Symfony, Doctrine, CakePHP, MongoDB, PHPUnit, Composer, Twig, Silex, and Swiftmailer, etc have all dropped support for HHVM.