search

ThaDafinser / UserAgentParser

UserAgent parsing done right
http://useragent.mkf.solutions/
MIT License
246 stars 47 forks source link

make getResult function public #84

Closed mimmi20 closed 8 years ago

mimmi20 commented 8 years ago

I would use your library in one of my projects, but I dont want to use your model. For this I like to make the getResult functions public.

I also fixed some small coding style issues and removed an useless line from the .php_cs file (this is overwritten by concat_with_spaces in line 45/46).

ThaDafinser commented 8 years ago

Thanks for the PR and sorry for the delay ...were on vacation.

Can't you use the getProviderResultRaw() for this use case? There is the raw result already in.

$result = $provider->parse('...valid UA');

$result->getProviderResultRaw(); // raw result from each provider

You can check the results here (just click on detail of each provider) http://useragent.mkf.solutions/

mimmi20 commented 8 years ago

I will check this.

mimmi20 commented 8 years ago

Could you look on the change in your .php_cs file?

ThaDafinser commented 8 years ago

@mimmi20 .php_cs change is done. What is with your feedback? Is it enough?

mimmi20 commented 8 years ago

I am using the getProviderResultRaw function now. Thanks.