The "No device model found" list contains strings that really do not have a model

ThaDafinser / UserAgentParserComparison

Comparison results from UserAgentParser

http://thadafinser.github.io/UserAgentParserComparison/

MIT License

28 stars 6 forks source link

The "No device model found" list contains strings that really do not have a model #23

Open NielsLeenheer opened 8 years ago

NielsLeenheer commented 8 years ago

I think this overview would be more useful if it only included strings that either:

have at least one model detected by a library
have a model according to the source

Example: http://thadafinser.github.io/UserAgentParserComparison/v4/user-agent-detail/93/d8/93d89c8a-7624-42f0-b3cf-372d90591b69.html

ThaDafinser commented 8 years ago

I've done that for botIsBot here https://github.com/ThaDafinser/UserAgentParserComparison/blob/master/bin/html/list-not-found-provider.php#L455

Would be similar here and for other lists as well.

The question is, if only the test suite is the master, or like you written have at least one result by a library is also valid

NielsLeenheer commented 8 years ago

I think the most useful way is to consider both. And if one of them has a model include it. It will probably add some noise from misidentifications, but then it will not depend just on the quality of library of the source. And if the source can't detect any model, but others can, it will be useful for the source to fix this.

ThaDafinser commented 8 years ago

Maybe provide two buttons for no detection

from test suite
from other results

NielsLeenheer commented 8 years ago

:+1: