ThaDafinser / ZfcDatagrid

New package available here (see website)
https://github.com/zfc-datagrid/zfc-datagrid/
MIT License
86 stars 57 forks source link

Todo for 2.0 #249

Closed ThaDafinser closed 7 years ago

ThaDafinser commented 8 years ago

Cleanup

setRendererName()

The renderer is now set though the setRendererService() method, so this method has no affect anymore https://github.com/ThaDafinser/ZfcDatagrid/blob/master/src/ZfcDatagrid/Datagrid.php#L789-L792

kokspflanze commented 8 years ago

from my site we should also update all tests to use ::class and not smth like https://github.com/ThaDafinser/ZfcDatagrid/blob/v1.3.0/tests/ZfcDatagridTest/DatagridTest.php#L160

we should also remove https://github.com/ThaDafinser/ZfcDatagrid/blob/v1.3.0/src/ZfcDatagrid/Datagrid.php#L1163 because of the changes of zend-mvc 2.7

ThaDafinser commented 8 years ago

Require PHP 7 + ZF3

kokspflanze commented 8 years ago

if we should only support PHP7, than we should also only support PHPUnit6 see https://github.com/sebastianbergmann/phpunit/issues/1751

kokspflanze commented 7 years ago

today i tried to set min PHP7 https://github.com/kokspflanze/ZfcDatagrid/tree/patch-5 the current problem i have is HHVM,

any one have a good idea expected --ignore-platform-reqs and remove hhvm from travis?

ThaDafinser commented 7 years ago

@kokspflanze i will get tomorrow back, where i will have some time to check the open issues and PR

ThaDafinser commented 7 years ago

@kokspflanze the temporary solution seems to be this part https://github.com/composer/composer/issues/4976

I guess I'll just move hhvm to the allow_failures list at Travis and use --ignore-platform-reqs until HHVM's PHP 7 compatible.

ThaDafinser commented 7 years ago

This issue was moved to zfc-datagrid/zfc-datagrid#30