ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.66k stars 143 forks source link

MyAnimeList support #134

Open Zabooby opened 2 years ago

Zabooby commented 2 years ago

Is support MAL sync planned?

ThaUnknown commented 2 years ago

no, MAL API is just dogshit [on the rare occasion it works], and I don't want to rely on fan-made 3rd part API's for MAL

however AniList exposes MAL ID's for most anime, so someone could easily make a PR based on that, which I'd likely accept

invalid issue template

ThaUnknown commented 2 years ago

I can't even look at their documentation https://haven.pages.dev/video-player/public/?file=https://cdn.discordapp.com/attachments/631919775613845504/962704977464266762/Desktop_2022.04.10_-_15.22.55.05.mp4

Zabooby commented 2 years ago

Couldn't you just copy taiga's implementation of MAL,they seem to have it working?

https://github.com/erengy/taiga

ThaUnknown commented 2 years ago

image image no lol

Zabooby commented 2 years ago

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

ThaUnknown commented 2 years ago

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

image

Zabooby commented 2 years ago

https://myanimelist.net/apiconfig/references/authorization https://myanimelist.net/static/apiagreement.html https://myanimelist.net/apiconfig/references/api/v2

Can you see these, maybe its because you don't have a MAL account?

Zabooby commented 2 years ago

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

ThaUnknown commented 2 years ago

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

that video is the perfect example of why I don't bother supporting MAL, if some1 makes a PR for it, I'll accept it, but I don't plan on working on it myself

Olyno commented 2 years ago

Hi 👋🏻 I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

ThaUnknown commented 2 years ago

Hi 👋🏻 I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

I recommend u read the list of features https://github.com/ThaUnknown/miru#features anilist is already supported, idk how u missed the big ass "login with anilist" button in the corner

Olyno commented 2 years ago

Oops sorry I didn't see it, I just stumbled upon this issue by chance, I should have been more careful, my apologies

Zabooby commented 2 years ago

Would any of these help with adding mal support?

https://github.com/Kylart/MalScraper https://github.com/Chris-Kode/myanimelist-api-v2 https://github.com/jikan-me/jikan

YUKI2eN3e commented 2 years ago

image image no lol

Maybe I'm completely misunderstanding how it works (I've only looked into Wasm pretty briefly), but couldn't you compile the C++/C code to Wasm and use it with your JavaScript code that way?

ThaUnknown commented 2 years ago

wow i cringed

It's not that its not possible in JS, its that i cant be fucking arsed to do it, because of how dogshit MAL is

ghost commented 2 years ago

Reopening this since its a good feature that many people would benefit from. It's not impossible, just troublesome because MAL has chosen it to be. As ThaUnknown said, he won't work on it himself but will accept PRs if someone else is willingly to implement.

Atkoset commented 2 years ago

Hello, could you add Kitsu API too if possible? Kitsu is comparable to Anilist in the way that it also syncs your anime. Where it differs is that it's fully opensource option that a lot of people including me use since it's opensource it shouldn't take too much work to integrate I hope. I have included a link to their API repo below.

https://github.com/hummingbird-me/api-docs

@ThaUnknown

ThaUnknown commented 2 years ago

as I stated before, I won't be pursuing this, but I'm open to accept PRs for it