[Feature Request]: Clipboard anilist anime link when user clicks on title

ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.

https://miru.watch

GNU General Public License v3.0

2.63k stars 144 forks source link

[Feature Request]: Clipboard anilist anime link when user clicks on title #190

Closed ghost closed 2 years ago

ghost commented 2 years ago

Preflight checklist

[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I have searched the features list for this feature, and I couldn't find it.
[X] I have checked that I'm using the latest stable version of the app.

Problem Description

Right now there is no way to copy a link from inside the app to easily share with other people, or to open it in the default browser.

Proposed Solution

Clicking the anime title on ViewAnime page would copy the anilist link for that anime to the clipboard.
Ctrl + click could open the anilist page for that anime in the default browser.

ThaUnknown commented 2 years ago

I'm not fond of hidden ghost functionality, as such I'm not a fan of how keybinds are currently implemented, how playing back torrents manually is implemented and how the user has no initial knowledge, so I'd rather not implement it in this way, instead have explicit buttons for "sharing" anime via miru, which would copy miru://anime/[alid] into their clipboard, which they then can paste into say discord, someone can click and it opens that anime in miru, and also have an external open icon, like W2G has for user profiles, which would open said anime on AL

ThaUnknown commented 2 years ago

I think there's another underling issue here. You want to open in it browser, because the app lacks some functionality, or is uncomfortable to navigate in some way, so you end up wanting to open it in browser? I think that's the reason here. Is there anything lacking from the viewAnime page in that sense?

ghost commented 2 years ago

because the app lacks some functionality

Yes. I know Miru isn't an anilist client so I'm gonna feedback some stuff, feel free to consider whatever. All of these required me to manually open the anilist page on browser in a way or another, ones more frequently than others:

I didn't like the anime, wanna drop it. You cannot drop an anime from inside the app.
Let's say I liked the anime and wanna read the manga/LN after watching an episode. I cannot add manga/LN to my list, or view if anime has a manga/LN.
I wanna check if this character has the same VA as another character from another anime (happens more frequently than you think). You can't view characters and their respective VAs.
I wanna see if my friends are watching the anime so I can hop on discord and discuss with them. I cannot see which friends are watching/have ptw the anime.
I finished an anime and wanna know what to watch next. No recommendations inside viewAnime.

is uncomfortable to navigate in some way

Also yes.

If I'm in a viewanime page open I cannot easily search for another anime without having to quit viewAnime and go back to Home Page to search, this adds a few clicks and is annoying to the point I simply don't use anything anilist related on Miru, specially when you can't press ESC to quit an animeView unless you select the animeView page with mouse.
I can't go to Home Page and start typing right away to search something.
Having to type the year when searching by season. If I'm gonna use the mouse to manually click the year box, might as well stay with the mouse instead of switching to keyboard. Could have an option in settings to switch from typing to dropdown.

ThaUnknown commented 2 years ago

YES YES YES

I didn't like the anime, wanna drop it.

you can, but I guess it's not.... how you expect it to be, it just removes it from the list, needs more work

LN

nah....

character

not sure tbh

friends watching

yes! will do.

recommendations

yes yes yes! issue is AL themselves recommendations have issues, but I'll add it regardless

Navigation: This is how I interpret the issues you're having and how I'd solve them

navigation

I'd like to keep in an overlay, its not the best, but I honestly don't know of a better way to design it without backwards state handling.... yucky! I'll resolve the ESC stuff

hope page typing

autofocus... yes will do!

year

this one is harder to solve, as i use only built-in form stuff, but I have an idea on how to do it I think navigating this entire thing with only keyboard via tab and arrows would be nice too, so i'll add that too

does this seem okay? or would you still think something is unreasonable or doesn't solve the underling feature?

ghost commented 2 years ago

does this seem okay? or would you still think something is unreasonable or doesn't solve the underling feature?

lgtm

ThaUnknown commented 2 years ago

27ac5cf0e8e483d508fef489e5d2eb01db2e2e84