ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.36k stars 133 forks source link

[Bug]: Ongoings in "Continue Watching" tab appearing only if there's unwatched episodes #349

Closed EnergoStalin closed 10 months ago

EnergoStalin commented 11 months ago

Preflight checklist

What app version are you using?

v4.4.12

What operating system version are you using?

Linux

Expected Behavior

Ongioing appear in "Continue Watching" after watching first and the only aired episode

Actual Behavior

It show's only when there's unwatched episodes

Screenshots

Episodes watched 1/12(aired 6) image

Episodes watched 1/12(aired 1) image image

EnergoStalin commented 11 months ago

The problem is here i think

https://github.com/ThaUnknown/miru/blob/916476aeb8c07b5026477bfde089eac53aa015f9/src/renderer/views/Home/Home.svelte#L45

1 < 1 in that case

I can see it useful to easily prevent watching ongoings episode by episode. But don't think it was the intention) looking on conditions above.

EnergoStalin commented 11 months ago

Sorry i missed purpose of Continue Watching i should've look better before submitting this. Issue of shame for me

Althrough i notice it heavily rely on anilist for aired episode data which can be updated later than episode aired on torrents.(kinda feel that way can't say for sure)

ThaUnknown commented 11 months ago

this is a regression from "airing episodes you missed" which miru had at the start, which was then renamed but code wasnt updated x)

EnergoStalin commented 11 months ago

I think it can be separate tab like was stated in #347. Current behavior completely okay it just need a little bit of understanding. Or maybe it's just mass schizophrenia about purpose of this tab) Because it's indeed purely logical to have only anime with unwatched episodes here to think of it. And you can get all ongoings you planning to watch in "You List" tab with airing filter if you want.

code wasnt updated x)

But if i guessed right and it's wont intended then do as you think would be more convenient

ThaUnknown commented 11 months ago

it just need a little bit of understanding

thats the issue, the app needs to be made with people that share 1 brain cell across their entire family tree, which is why I re-opened this, because I myself realised at one point "hm shouldnt this have other stuff too?"

ThaUnknown commented 10 months ago

after thinking more about this, this is intended behavior, I don't see a point in "continue watching" of a show that u cant actually continue watching?

EnergoStalin commented 10 months ago

Yes. Like i said i'm happy with that