ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.18k stars 125 forks source link

[Bug]: Subtitle select firing faster than external files buffering #394

Closed EnergoStalin closed 7 months ago

EnergoStalin commented 7 months ago

Preflight checklist

What app version are you using?

4.5.6

What operating system version are you using?

Linux

Expected Behavior

Fire tracks event only when all relevant files from batch preloaded. No need to hurry.

Actual Behavior

It firing only with embedded tracks discarding tracks from external files cause its not present at the moment of first call of.

https://github.com/ThaUnknown/miru/blob/0a282027a6d5f9ef60db519aa2e0170b0e6d67d4/common/modules/subtitles.js#L62

And then it shows up as Track 4 instead of intended Track 0 ending up with Eng embedded subtitles selected

Seems like it can happen only on batch torrents since only they might have external subtitle files.

I feel it can be reproduced on any torrent with external subtitles and which takes a couple seconds to load or less.

When torrent already preloaded it works smooth.

Screenshots

No response