ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.13k stars 123 forks source link

Add subscene integration #441

Closed shellawa closed 2 months ago

shellawa commented 2 months ago

Barely got it to work, but I added a subscene panel in the subtitle menu, where you can find subtitles there and add them directly to the playing video without having to leave the app. I never actually do frontend stuff before, so I just put random css in and hoping for the best. Also there are still issues I found, listed here:

image image image

ThaUnknown commented 2 months ago

ignoring the fact that the code is.... bad...., I'm not interested in this

this adds an extra dependency to Miru, this comes with a lot of issues down the line, subs will become depended on a 3rd party service, have issues with "hey these subs are wrong", or "this episode is wrong", or "this show isn't" correct

Miru already depends on AniList, AniZip and Tosho, if one of those goes down, Miru stops, I don't want another dependency in the mix

Many subs in subscene will come from torrents anyways, so the user can simply pick a different torrent that has these subtitles