[Bug]: Portable Version installs when newer version available (Update functionality)

EpicGazel commented 2 months ago

Preflight checklist

[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I have searched the frequently asked questions for a solution that fixes this problem, without success.
[X] I have checked that I'm using the latest stable version of the app.

What app version are you using?

v5.0.12

What operating system version are you using?

Windows

Expected Behavior

The portable version should not attempt to and successfully install an updated version upon closing.

Actual Behavior

While running the portable version, an update will be found, downloaded, and installed upon closing. This adds files and a desktop icon, all of which are unprompted.

Screenshots

No response

vvirtues commented 2 months ago

might not be directly related but the winget repo uses the portable instead of the installer , I can update that if you want

vvirtues commented 2 months ago

Review if you want it: https://github.com/microsoft/winget-pkgs/pull/152606

ThaUnknown commented 3 weeks ago

this should be fixed in 5.1.2, but since it's fixed in that version, we'll need to wait for 5.1.3 to verify if it was actually fixed

EpicGazel commented 3 weeks ago

Still not fixed going from 5.1.3 -> 5.1.4

EpicGazel commented 2 weeks ago

Still not fixed going from 5.1.4 -> 5.1.6

ThaUnknown commented 2 weeks ago

this is unlikely to be fixed, since it's an issue with electron build dependencies, not miru itself

EpicGazel commented 1 week ago

Band-aid solution for others, delete or rename %localappdata%/miru-updater No installer.exe means no install

ThaUnknown / miru