ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.47k stars 139 forks source link

[Bug]: Default font doesn't support japanese characters #454

Closed Lolirag closed 3 months ago

Lolirag commented 4 months ago

Preflight checklist

What app version are you using?

v5.1.0

What operating system version are you using?

Windows

Expected Behavior

When inputting external subtitles, the Japanese Text would display properly. (I expect Japanese to be supported, given the Preferred Subtitled Language setting.)

Actual Behavior

Instead, all the characters are errors.

Having tested various different subtitles with various series, external subtitles of the romance language have no issue. Japanese however, does. Have also tested on other media players, and they expectedly display without issue.

Screenshots

Miru_FTQXrzABVE Miru_i7G6vNyTP2

ThaUnknown commented 4 months ago

the default fallback font in miru doesn't support japanese characters, you'll need to install a font on your PC that does, then set that as default fallback font in settings

Lolirag commented 4 months ago

It seems I'm retarded. Thanks.

ThaUnknown commented 4 months ago

nah, I considered making a font that supports jp sub

dfireBird commented 3 months ago

I tried changing the default subtitle font to 'Noto Sans CJK JP' but I get the error in screenshot. image

ThaUnknown commented 3 months ago

huh, cool

ThaUnknown commented 3 months ago

@dfireBird this is fixed in 5.1.2 https://github.com/ThaUnknown/miru/commit/33f9124cc9b9d3831413a636b70dfc0bf66f0613

there's not an easy to fix this, however the solution is "use a fallback font which has japanese characters", but if the release includes a font, which doesnt support jp characters, then proceeds to create fonts which have jp chars, this wont work, so i'm gonna track this issue in https://github.com/ThaUnknown/miru/issues/329

GioGioWasTaken commented 1 month ago

[Redacted]

Local system issue with font config in javascript. Really, really weird. Fixed it and also updated to latest version.

Truly sorry.