ThaUnknown / miru

Bittorrent streaming software for cats. Stream anime torrents, real-time with no waiting for downloads.
https://miru.watch
GNU General Public License v3.0
2.36k stars 133 forks source link

[Bug]: Miru AppImages breaks upon trying to update #481

Open Hexality opened 1 month ago

Hexality commented 1 month ago

Preflight checklist

What app version are you using?

v5.2.3

What operating system version are you using?

Linux

Expected Behavior

Updates the AppImage

Actual Behavior

Shows the update notification then nukes itself upon restarting, deleting the .AppImage file and breaking the app.

Also, please add an option to disable auto-updates, as some people (like me) uses softwares such as Gearlever to manage and update them and having auto-updates most of the time break the software.

Screenshots

image

Hexality commented 1 month ago

also, before it would just nuke itself and I could redownload and run, but after the update before the last, it started loopnuking itself. You download it again, it deletes itself and shows the same error upon launch.

ThaUnknown commented 1 month ago

Yeah this is annoying, and odd? Miru tells macOS to update the app, and macOS does nothing, idfk, why is it so hard to get macOS to do anything, fucks sake

Hexality commented 1 month ago

Yeah this is annoying, and odd? Miru tells macOS to update the app, and macOS does nothing, idfk, why is it so hard to get macOS to do anything, fucks sake

Also happens on macOS? maybe its something mutual between *nix systems then(?)

ThaUnknown commented 1 month ago

oh shit, i thought this was a mac issue, yeah idk about linux, it should just work? that just looks like some corruption during update

Hexality commented 1 month ago

oh shit, i thought this was a mac issue, yeah idk about linux, it should just work? that just looks like some corruption during update

Like, from my over-context understanding, it feels like Miru is trying to update its files onto the AppImage's mountfs, which is temporary, which ends up making the app nuke itself since it will keep trying to launch back from a place that no longer exists (/tmp/.mount_miru_randomId/opt/Miru/ / /tmp/.mount_miru_randomId/resources/app.asar)

Hexality commented 1 month ago

I think the only fix for this would be relying on a insteance check to see if the app is running from a temporary volume, this would probably also benefit macOS. In the case of macOS I don't know how it handles self-updates from the app but if possible you could add something like a binary update instead or, like peppy did with osu, a notification with a onclick action directing the user to the https://github.com/ThaUnknown/Miru/releases/latest/

ThaUnknown commented 1 month ago

I don't implement my own auto updater, i use electron's auto updater, so it's likely smth to bring up with them

ThaUnknown commented 1 month ago

.14 will fix this, you'll need to wait till .15 to test