search

ThaUnknown / webtorrent-player

High performance, no compromise video player for WebTorrent
https://thaunknown.github.io/webtorrent-player/
GNU General Public License v3.0
71 stars 21 forks source link

Fixed Typo: kB to KB #2

Closed combe15 closed 3 years ago

combe15 commented 3 years ago

Fixed a typo for the abbreviation KiloBytes.

Kirdow commented 3 years ago

Writing kilobytes as KB with capital K is only really considered when dividing by 1024. If you're dividing by 1000 like when you use the metric scale, as this code is currently doing, you're generally writing it as kB rather than KB. So in that regard, there is no typo here.

Source: https://en.wikipedia.org/wiki/Kilobyte

ThaUnknown commented 3 years ago

Writing kilobytes as KB with capital K is only really considered when dividing by 1024. If you're dividing by 1000 like when you use the metric scale, as this code is currently doing, you're generally writing it as kB rather than KB. So in that regard, there is no typo here.

Source: https://en.wikipedia.org/wiki/Kilobyte

tru, but kB look bad

combe15 commented 3 years ago

changethestandard

It's dumb and nobody truly follows it anyways. it's close enough IMO. nobody is going to bat an eye at missing 24 bytes in this case. Even this popular education platform talking about the sizes gets the abbreviation wrong. www.geeksforgeeks.org/understanding-file-sizes The standard should be that Kilobyte == KB and Kibibyte== KiB The current standard doesn't make intuitive sense and nobody following it doesn't make it much of a standard, now does it?

But that's just my opinion.

ThaUnknown commented 3 years ago

changethestandard

It's dumb and nobody truly follows it anyways. it's close enough IMO. nobody is going to bat an eye at missing 24 bytes in this case. Even this popular education platform talking about the sizes gets the abbreviation wrong. www.geeksforgeeks.org/understanding-file-sizes The standard should be that Kilobyte == KB and Kibibyte== KiB The current standard doesn't make intuitive sense and nobody following it doesn't make it much of a standard, now does it?

But that's just my opinion.

or you could just say "it luk bad" winning argument right there.

combe15 commented 3 years ago

changethestandard

It's dumb and nobody truly follows it anyways. it's close enough IMO. nobody is going to bat an eye at missing 24 bytes in this case. Even this popular education platform talking about the sizes gets the abbreviation wrong. www.geeksforgeeks.org/understanding-file-sizes The standard should be that Kilobyte == KB and Kibibyte== KiB The current standard doesn't make intuitive sense and nobody following it doesn't make it much of a standard, now does it? But that's just my opinion.

or you could just say "it luk bad" winning argument right there.

It looks bad and I don't like it.