search

ThaUnknown / webtorrent-player

High performance, no compromise video player for WebTorrent
https://thaunknown.github.io/webtorrent-player/
GNU General Public License v3.0
71 stars 21 forks source link

parser misses large font files #6

Closed ThaUnknown closed 3 years ago

ThaUnknown commented 3 years ago

the parser misses large font files, this happens consistently on PAS releases, I assume this is because of my changes to how the parser is initiated in order to fix the pieced metadata not being parsed which would result in nothing being parsed at all.

This shouldn't be a fix, more a patch since the original issue is way worse, maybe create an additional linear parser on top of the stream parser which parses infinitely until it reaches empty headers or the first subtitle file, it should be fine to assume that the font files would be parsed before any subtitles? additionally this means that the subtitle renderer wouldn't be initiated until all the font files were created?

ThaUnknown commented 3 years ago

the underlying issue is 1/2 webtorrent's fault and 1/2 parser's fault, since readable-stream will be yeeted, won't bother fixing this for now, it isn't a big issue in most releases anyways.

ThaUnknown commented 3 years ago

https://github.com/ThaUnknown/webtorrent-player/commit/2fa54294b6fd21da3cf30db5df6506fded84fa9b so much for wontfix