ThakurBallary / react-native-radio-buttons-group

Simple, best and easy to use radio buttons for react native apps.
MIT License
263 stars 71 forks source link

Typescript issue with lodash function #50

Closed azuken closed 1 year ago

azuken commented 1 year ago

Since I bumped to RN 0.71.0, I've changed some eslint rules, and I have a Typescript error from this lib, which says that a declaration file is missing for 'lodash.isequal', in RadioGroup.tsx file.

Can it be fixed ?

Here is the full description :

TS7016: Could not find a declaration file for module 'lodash.isequal'. '/Users/xxxx/node_modules/lodash.isequal/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/lodash.isequal` if it exists or add a new declaration (.d.ts) file containing `declare module 'lodash.isequal';`
papidb commented 1 year ago

Run yarn add -D @types/lodash.isequal to remove the error.

azuken commented 1 year ago

It is not a good solution. I do not want to add a peer dependency from this package explicitly, it must be added to this package dependencies.

ThakurBallary commented 1 year ago

@azuken @papidb thanks for writing!! Added @types/lodash.isequal in devDependencies

DavidGonzalezGutierrez commented 1 year ago

Sorry but you put @types/lodash-isequal instead of @types/lodash.isequal in dev dependencies.

ThakurBallary commented 1 year ago

Updated. Thank you @DavidGonzalezGutierrez