ThakurBallary / react-native-status-color-picker

Customizable color picker for your beautiful react native apps
MIT License
8 stars 5 forks source link

Expo vector-icons dependency not defined #2

Open sambwest opened 5 years ago

sambwest commented 5 years ago

You are including @expo/vector-icons but it's not in the package.json as a dependency. Anyone not using expo cannot use this.

nazrdogan commented 5 years ago

same issue

juniorerico commented 5 years ago

You can use the icons from react-native-vector-icons.

1 - yarn add react-native-vector-icons or npm install --save react-native-vector-icons

2 - react-native link react-native-vector-icons

3 - Go files lib/ColorPicker.js and lib/FullScreenColorStatus.js

4 - Replace: import { MaterialCommunityIcons as Icon } from '@expo/vector-icons'; by import Icon from 'react-native-vector-icons/MaterialCommunityIcons';

alexmcode commented 5 years ago

This is very unprofessional! Please don't make this package public if it's not ready for usage. It makes us waste time and energy.