Swedish Folkskola Yields

[stackpoint]

It seems like the Sweedish UB does not have any of the default public school yields. I also don't think the building has any unique traits. Below is the code that's needed in CEC__End.sql to bring the UB up to public school yields:

INSERT INTO Building_YieldChanges(BuildingType, YieldType, Yield)
SELECT 'BUILDING_FOLKSKOLA', 'YIELD_SCIENCE', 3;

INSERT INTO Building_YieldChangesPerPop(BuildingType, YieldType, Yield)
SELECT 'BUILDING_FOLKSKOLA', 'YIELD_SCIENCE', 50;

I can't remember what was unique about the building in GEM so I can't write anything in regards to that.

[GrantSP]

You're correct. Again. It was one of the very first edits I made when I joined Thal at the start of the year. I was still learning a great deal about how the different changes to the tables affect the units/buildings etc.

Having a quick look in the forum, it appears only you and 1 or 2 others have noticed this. I wonder, is it because very few play as Sweden or are you and they just more observant?

If you are going to make those changes, and I encourage you to do so. I would ask that you make the changes in the file where the Folkskola is defined, CEL__J_Z.xml. Thal likes to keep all the stuff related to leader specific changes in the same location. If you were making changes to ALL Public School buildings, then yeah, CEC__End.sql is the place.

The only requirements Thal asked for were, early in the tech tree and give a science boost. Maybe a change to the 'GreatScientistBeakerModifier' in the Buildings table? Or just a small change to those Yields? Your choice.

On 6 November 2013 09:27, stackpoint notifications@github.com wrote:

It seems like the Sweedish UB does not have any of the default public school yields. I also don't think the building has any unique traits. Below is the code that's needed in CEC__End.sql to bring the UB up to public school yields:

INSERT INTO Building_YieldChanges(BuildingType, YieldType, Yield)SELECT 'BUILDING_FOLKSKOLA', 'YIELD_SCIENCE', 3; INSERT INTO Building_YieldChangesPerPop(BuildingType, YieldType, Yield)SELECT 'BUILDING_FOLKSKOLA', 'YIELD_SCIENCE', 50;

I can't remember what was unique about the building in GEM so I can't write anything in regards to that.

— Reply to this email directly or view it on GitHubhttps://github.com/Thalassicus/cepbasic/issues/5 .

"There are 10 types of people in the world: those who understand binary, and those who don't."

[stackpoint]

I would be glad to push an update myself but I'm actually having trouble using github for windows.

If you wouldn't mind updating it for me:

<Building_YieldChanges>
        <Row>
                <BuildingType>BUILDING_FOLKSKOLA</BuildingType>
                <YieldType>YIELD_SCIENCE</YieldType>
                <Yield>3</Yield>
        </Row>
</Building_YieldChanges>

<Building_YieldChangesPerPop>
        <Row>
                <BuildingType>BUILDING_FOLKSKOLA</BuildingType>
                <YieldType>YIELD_SCIENCE</YieldType>
                <Yield>50</Yield>
        </Row>
</Building_YieldChangesPerPop>

Also, I assume that the GreatScientistBeakerModifier stacks? So each public school would give +X% to great scientist generation. I guess +5% per school would be a good start since it is a later game building and you would need to build 10 of them at 5% to match Babylon's unique trait.

[GrantSP]

No problem. I'll do it right away.

What sort of trouble is GitHub giving you? Thal and I had a nightmare in the beginning trying to get commits to work properly, part of the reason why I work on a branch of the main repo rather using a forked version and pushing commits. I can happily say now though that the more I use Git the more I can see it as an invaluable tool.

On 6 November 2013 10:25, stackpoint notifications@github.com wrote:

I would be glad to push an update myself but I'm actually having trouble using github for windows.

If you wouldn't mind updating it for me:

BUILDING_FOLKSKOLA YIELD_SCIENCE 3 BUILDING_FOLKSKOLA YIELD_SCIENCE 50

Also I assume that the GreatScientistBeakerModifier stacks? So each public school would give +X% to great scientist generation. I guess +5% per school would be a good start since it is a later game building and you would need to build 10 of them to match Babylon's unique trait.

— Reply to this email directly or view it on GitHubhttps://github.com/Thalassicus/cepbasic/issues/5#issuecomment-27824188 .

"There are 10 types of people in the world: those who understand binary, and those who don't."

[stackpoint]

Having trouble merging my forked repo with the master repo among other things. I'll close this since you've fixed the issue.

[GrantSP]

What sort of problem? Detached head? Most merge errors result from your code being 1 or more commits out of sync either way, either behind or ahead. If you open a Git shell and use "git status" what messages does it give you? The git shell is a very powerful tool and has helped me resolve a lot of errors.

On 6 November 2013 13:47, stackpoint notifications@github.com wrote:

Having trouble merging my forked repo with the master repo among other things. I'll close this since you've fixed the issue.

— Reply to this email directly or view it on GitHubhttps://github.com/Thalassicus/cepbasic/issues/5#issuecomment-27837135 .

"There are 10 types of people in the world: those who understand binary, and those who don't."