Thalassicus / cep-bnw

Civ V Communitas Expansion Pack
32 stars 22 forks source link

Venice gets settler for building pyramids #124

Closed qqqbbb closed 10 years ago

qqqbbb commented 10 years ago

Maybe replace that settler with merchant of venice?

stackpoint commented 10 years ago

Yes, it probably should.

Best (only?) way to do this is through the lua. Though there's a lot of lua running overhead already. We may have to write a custom lua code that grants a settler/merchant.

I believe all the settler -> merchant conversions in vanilla is done with the DLL.

stackpoint commented 10 years ago

Here's some background on the Venice settler conversion: http://forums.civfanatics.com/showthread.php?t=500676

Looks like using the BuildingConstructed hook to check if the leader has NoAnnexing active then to find the settler and replace it seems to be the way to go.

Thalassicus commented 10 years ago

I'd use the NewUnit lua event instead of BuildingConstructed. That will point to the settler. The building might be created before the settler, which might mean no settler exists yet when BuildingConstructed runs.

Thalassicus commented 10 years ago

Fixed this bug.