search

Thalassicus / cep-bnw

Civ V Communitas Expansion Pack
32 stars 22 forks source link

Golden Age Yield Modifiers #168

Closed stackpoint closed 10 years ago

stackpoint commented 10 years ago
stackpoint commented 10 years ago

This should activate the +20% modifiers for production, gold, and science. Also will cause the tooltips to incorrectly display that +20% modifier is active while there aren't any actual additional yields being produced. The rest will require YieldLibrary to handle the extra yields.

GrantSP commented 10 years ago

I could have sworn I was getting 50% longer GA times with Persia, now I'm not. The database still shows a 50% in the GoldenAgeDurationModifier, did we change something in the last commit or two? I'm only having 10 turn GA lengths not 15 as expected.

stackpoint commented 10 years ago

What are you using to trigger the golden age?

GrantSP commented 10 years ago

Playing the game as normal. Just having a break from bugfixing for an hour or two and noticed it.

stackpoint commented 10 years ago

The golden age duration modifier and the combat modifier needs to be removed from the trait as well.

GrantSP commented 10 years ago

Huh. So we are making the GA lengths the same for them as for the others? That modifier is still active why aren't we getting longer GAs?

I like those parts of the Persian UA. When was this decided?

stackpoint commented 10 years ago

Persia's UA reads:

INSERT INTO Cep_Language_EN_US (DateModified, Tag, Text, Gender, Plurality) VALUES (date('2013-01-18'), 'TXT_KEY_TRAIT_ENHANCED_GOLDEN_AGES', '+50% [ICON_CULTURE] Culture and +1[ICON_MOVES] Movement during [ICON_GOLDEN_AGE] Golden Ages.[NEWLINE]Starts with a unique Spearman.', '', '');
GrantSP commented 10 years ago

I was just assuming our additions were just that, additions not replacements. IMHO this makes it a pretty poor UA then. Big deal +1 to movement & +50% Culture. The greater length of a GA and the normal +20% Culture is pretty good. Ah well, may be some balancing discussions in the forum again.

Thanks @stackpoint

stackpoint commented 10 years ago

It doesn't make sense to leave part of the UA's description out of the text. It's possible that the golden age length modifier and the combat modifier were supposed to be left in and if that's the case then that should be added back into the text description.

And I just ran a test with Persia. Golden ages did receive their 50% bonus. Were you starting golden ages with great people? That could explain the reduced turn count.

GrantSP commented 10 years ago

By great people and just as per normal. How strange.

Agreed about the description but I don't know what the actual rationale for this UA was. I'll check back through the forum discussions later.

stackpoint commented 10 years ago

These should be fixed with the activation of the city yields from the YieldLibrary. Any further yield issues should be brought up in the following issue: https://github.com/Thalassicus/cep-bnw/issues/179